Generate snapshot for dartj2s; use it in the SDK.

Generate snapshot for dartj2s; use it in the SDK.

Committed: https://code.google.com/p/dart/source/detail?r=13773

[dgrove, 2012-10-17 12:59:17]

LGTM! It'll be great to see this in action.

https://codereview.chromium.org/11187028/diff/1/dart/utils/compiler/build_hel...
File dart/utils/compiler/build_helper.dart (right):

https://codereview.chromium.org/11187028/diff/1/dart/utils/compiler/build_hel...
dart/utils/compiler/build_helper.dart:124:
SNAPSHOT="--use_script_snapshot=\$BIN_DIR/${path}.snapshot"
you want quotes around \$BIN_DIR to deal with BIN_DIR containing spaces.

[kasperl, 2012-10-17 13:00:38]

LGTM.

[ahe, 2012-10-17 13:03:07]

Thank you, Dan and Kasper for the quick review.

I'm going to land this in a few minutes and keep my fingers crossed.

https://codereview.chromium.org/11187028/diff/1/dart/utils/compiler/build_hel...
File dart/utils/compiler/build_helper.dart (right):

https://codereview.chromium.org/11187028/diff/1/dart/utils/compiler/build_hel...
dart/utils/compiler/build_helper.dart:124:
SNAPSHOT="--use_script_snapshot=\$BIN_DIR/${path}.snapshot"
On 2012/10/17 12:59:17, dgrove wrote:
> you want quotes around \$BIN_DIR to deal with BIN_DIR containing spaces.

Actually, there are quotes around everything. That should be sufficient. But I
will test it.

[ahe, 2012-10-17 13:44:46]

Sadly, gen_snapshot crashes on Linux and in debug builds. I have filed
http://dartbug.com/5989 :-(

[ahe, 2012-10-17 18:13:36]

Wow! Siva already fixed this bug. I'll try to submit this CL tomorrow morning.

[ahe, 2012-10-17 18:40:22]

On a Z620:

Before:

$ ./tools/test.py -mrelease -cdart2js -rd8 --use-sdk
[09:59 | 100% | + 5469 | -    0]

After:

$ ./tools/test.py -mrelease -cdart2js -rd8 --use-sdk
[07:14 | 100% | + 5469 | -    0]

28% reduction in test time!

[ahe, 2012-10-17 20:19:05]

On my desktop Mac Pro (Quad-Core Intel Xeon 2,66 GHz).

Before:

$ ./tools/test.py -mrelease -cdart2js -rd8 --use-sdk
[47:58 | 100% | + 5467 | -    0]

After:

$ ./tools/test.py -mrelease -cdart2js -rd8 --use-sdk
[35:05 | 100% | + 5467 | -    0]

27% reduction in test time.