Add a Pub test that runs against the real Dart SDK.

Add a Pub test that runs against the real Dart SDK.

BUG=5906
Committed: https://code.google.com/p/dart/source/detail?r=13708

[Bob Nystrom, 2012-10-16 21:00:02]

https://codereview.chromium.org/11187011/diff/1/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/11187011/diff/1/utils/tests/pub/test_pub.dart...
utils/tests/pub/test_pub.dart:623: /// test, and that the test will always run
on the build bot.
"and" -> "but"

https://codereview.chromium.org/11187011/diff/1/utils/tests/pub/test_pub.dart...
utils/tests/pub/test_pub.dart:646: join(testDirectory, '../../../out', name));
This directory is only "out" on Linux. On Mac, it's "xcodebuild" and on Windows
it's "build".

[nweiz, 2012-10-16 21:09:24]

https://codereview.chromium.org/11187011/diff/1/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/11187011/diff/1/utils/tests/pub/test_pub.dart...
utils/tests/pub/test_pub.dart:623: /// test, and that the test will always run
on the build bot.
On 2012/10/16 21:00:02, Bob Nystrom wrote:
> "and" -> "but"

Done.

https://codereview.chromium.org/11187011/diff/1/utils/tests/pub/test_pub.dart...
utils/tests/pub/test_pub.dart:646: join(testDirectory, '../../../out', name));
On 2012/10/16 21:00:02, Bob Nystrom wrote:
> This directory is only "out" on Linux. On Mac, it's "xcodebuild" and on
Windows
> it's "build".

It's like they want this to be difficult :p. Fixed.

[Bob Nystrom, 2012-10-16 21:14:20]

https://codereview.chromium.org/11187011/diff/4001/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/11187011/diff/4001/utils/tests/pub/test_pub.d...
utils/tests/pub/test_pub.dart:641: final List<String> _buildParentNames =
['out', 'xcodebuild', 'build'];
How about just making this a map of Platform.operatingSystem values to
directories:

final _buildDirectories = {'mac': 'xcodebuild', 'linux': 'out', 'windows':
'build}

And then just look it up using the current OS?

[nweiz, 2012-10-16 22:00:13]

https://codereview.chromium.org/11187011/diff/4001/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/11187011/diff/4001/utils/tests/pub/test_pub.d...
utils/tests/pub/test_pub.dart:641: final List<String> _buildParentNames =
['out', 'xcodebuild', 'build'];
On 2012/10/16 21:14:20, Bob Nystrom wrote:
> How about just making this a map of Platform.operatingSystem values to
> directories:
> 
> final _buildDirectories = {'mac': 'xcodebuild', 'linux': 'out', 'windows':
> 'build}
> 
> And then just look it up using the current OS?

Done.

[Bob Nystrom, 2012-10-16 22:04:16]

I'm getting the "old chunk mismatch" error. Can you upload your changes again?

[nweiz, 2012-10-16 22:19:48]

Done.

[Bob Nystrom, 2012-10-16 22:23:38]

LGTM!