Issue 11187003: Fix receiver's type for constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11187003: Fix receiver's type for constructors. (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix receiver's type for constructors. Committed: https://code.google.com/p/dart/source/detail?r=13685

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+19 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/11187003/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (left): https://codereview.chromium.org/11187003/diff/1/runtime/vm/flow_graph_optimizer.cc#oldcode2136 runtime/vm/flow_graph_optimizer.cc:2136: if (((param->index() == 0) && function.IsDynamicFunction()) || It ...

8 years, 2 months ago (2012-10-16 16:10:11 UTC) #1

srdjan

8 years, 2 months ago (2012-10-16 16:18:19 UTC) #2

https://codereview.chromium.org/11187003/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (left):

https://codereview.chromium.org/11187003/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2136: if (((param->index() == 0) &&
function.IsDynamicFunction()) ||
On 2012/10/16 16:10:11, regis wrote:
> It looks like your change is only inserting || function.IsConstructor() here.
It
> is otherwise just style, or do I miss something?

Yes. IMO, it was hard to read and I thought that we have two different cases and
keep them separate.

https://codereview.chromium.org/11187003/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11187003/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2142: if ((param->index() == 1) &&
parsed_function().function().IsConstructor()) {
On 2012/10/16 16:10:11, regis wrote:
> How about an else here?

Done.

Expand Messages | Collapse Messages

Issue 11187003: Fix receiver's type for constructors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages