Issue 11186064: Enforce new optional parameter rules.

Issue 11186064: Enforce new optional parameter rules. (Closed)

Created:
8 years, 2 months ago by regis

Modified:
8 years, 2 months ago

Reviewers:
kasperl, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enforce new optional parameter rules. Committed: https://code.google.com/p/dart/source/detail?r=13891

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -10 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	2 chunks	+39 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11186064/diff/2001/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11186064/diff/2001/tests/co19/co19-dart2dart.status#newcode24 tests/co19/co19-dart2dart.status:24: Language/06_Functions/2_Formal_Parameters/2_Optional_Formals_A01_t03: Fail Fail, OK? https://codereview.chromium.org/11186064/diff/2001/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): ...

8 years, 2 months ago (2012-10-22 12:14:41 UTC) #2

regis

Thanks! https://codereview.chromium.org/11186064/diff/2001/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11186064/diff/2001/tests/co19/co19-dart2dart.status#newcode24 tests/co19/co19-dart2dart.status:24: Language/06_Functions/2_Formal_Parameters/2_Optional_Formals_A01_t03: Fail On 2012/10/22 12:14:41, kasperl wrote: > ...

8 years, 2 months ago (2012-10-22 16:27:52 UTC) #3

LGTM -ip

Expand Messages | Collapse Messages