Issue 11186048: Fix bad mangling of environment parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11186048: Fix bad mangling of environment parameters. (Closed)

Created:
8 years, 2 months ago by floitsch

Modified:
8 years, 1 month ago

Reviewers:
erikcorry, ngeoffray

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bad mangling of environment parameters. Committed: https://code.google.com/p/dart/source/detail?r=14517

Patch Set 2 : Update comments. #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -40 lines)			Patch
M	lib/compiler/implementation/ssa/codegen.dart	View		6 chunks	+31 lines, -20 lines	2 comments	Download
M	lib/compiler/implementation/ssa/variable_allocator.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
A +	tests/language/state_mangling3_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
A +	tests/language/state_mangling4_test.dart	View		2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11186048/diff/2001/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/11186048/diff/2001/lib/compiler/implementation/ssa/codegen.dart#newcode1106 lib/compiler/implementation/ssa/codegen.dart:1106: String tempName, Why parameterizing tempName? It's swapTemp for ...

8 years, 2 months ago (2012-10-25 11:27:45 UTC) #2

floitsch

8 years, 1 month ago (2012-10-31 14:49:19 UTC) #3

https://codereview.chromium.org/11186048/diff/2001/lib/compiler/implementatio...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11186048/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/ssa/codegen.dart:1106: String tempName,
On 2012/10/25 11:27:45, ngeoffray wrote:
> Why parameterizing tempName? It's swapTemp for both calls.

I don't want sequentializeCopies to deal with the variableNames object. It's
taking String->String mappings and returns String->String mappings.

Expand Messages | Collapse Messages

Issue 11186048: Fix bad mangling of environment parameters. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Update comments. #

Messages