Inline indexed store ([]=) array operations in checked mode.

Inline indexed store ([]=) array operations in checked mode.
Committed: https://code.google.com/p/dart/source/detail?r=13794

[srdjan, 2012-10-18 16:25:48]

LGTM with comment, please wait for Regis to LGTM it as well.
Can you also add a test, or verify that the existing tests are
triggering/executing the optimized code.

https://codereview.chromium.org/11186047/diff/3001/runtime/vm/flow_graph_opti...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11186047/diff/3001/runtime/vm/flow_graph_opti...
runtime/vm/flow_graph_optimizer.cc:462: InsertBefore(call, assert_index, NULL,
Definition::kValue);
Do we need the index check at all, since it will be done as part of StoreIndexed
code. (deoptimizes if index is not integer).

[regis, 2012-10-18 17:07:26]

LGTM

https://codereview.chromium.org/11186047/diff/3001/runtime/vm/flow_graph_opti...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11186047/diff/3001/runtime/vm/flow_graph_opti...
runtime/vm/flow_graph_optimizer.cc:491: UNREACHABLE();
How about a comment explaining that other array flavors are not inlined yet?

[Florian Schneider, 2012-10-18 18:13:10]

I checked for test coverage and the optimization is triggered in a large number
of the existing checked-mode tests.

https://codereview.chromium.org/11186047/diff/3001/runtime/vm/flow_graph_opti...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11186047/diff/3001/runtime/vm/flow_graph_opti...
runtime/vm/flow_graph_optimizer.cc:462: InsertBefore(call, assert_index, NULL,
Definition::kValue);
On 2012/10/18 16:25:48, srdjan wrote:
> Do we need the index check at all, since it will be done as part of
StoreIndexed
> code. (deoptimizes if index is not integer).

Good point. I agree that we don't need it here. The unoptimized code will take
care of throwing the proper exception in case the index is not a smi.

https://codereview.chromium.org/11186047/diff/3001/runtime/vm/flow_graph_opti...
runtime/vm/flow_graph_optimizer.cc:491: UNREACHABLE();
On 2012/10/18 17:07:26, regis wrote:
> How about a comment explaining that other array flavors are not inlined yet?

Done.