Issue 11186007: In optimized code always deoptimize if we encounter an instance call without type feedback (ICData …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11186007: In optimized code always deoptimize if we encounter an instance call without type feedback (ICData … (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, zerny-google, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

In optimized code always deoptimize if we encounter an instance call without type feedback (ICData has no checks). Fix a bug in inliner: do not inline methods that have no compiled code as we can not deoptimize into them. This is the simplest fix, more complex fixes can be implemented if we see a need for them. This improves the speed of Meteor by 15% and NavierStokes by 40% (Mac OS X). Committed: https://code.google.com/p/dart/source/detail?r=13712

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -9 lines)			Patch
M	runtime/vm/code_generator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+22 lines, -8 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages