Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1118423003: Handle default values on constant redirecting factories. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, karlklose
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Handle default values on constant redirecting factories. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=45490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -110 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 5 chunks +153 lines, -110 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/const_redirecting_factory_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-04 11:46:14 UTC) #2
sigurdm
LGTM
5 years, 7 months ago (2015-05-04 13:09:44 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-05-04 13:39:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698