Issue 11184046: Clean up leg.dart.

Issue 11184046: Clean up leg.dart. (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, compiler-dev_google.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Clean up leg.dart. Committed: https://code.google.com/p/dart/source/detail?r=13809

Patch Set 2 : Rebased on CL 11187067 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+398 lines, -357 lines)			Patch
M	dart/lib/compiler/implementation/apiimpl.dart	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	dart/lib/compiler/implementation/closure.dart	View		1 chunk	+5 lines, -6 lines	0 comments	Download
M	dart/lib/compiler/implementation/dart2jslib.dart	View		1 chunk	+39 lines, -35 lines	0 comments	Download
M	dart/lib/compiler/implementation/dart_backend/dart_backend.dart	View	1	1 chunk	+17 lines, -12 lines	0 comments	Download
M	dart/lib/compiler/implementation/elements/elements.dart	View		1 chunk	+20 lines, -8 lines	0 comments	Download
M	dart/lib/compiler/implementation/js/js.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	dart/lib/compiler/implementation/js_backend/js_backend.dart	View		1 chunk	+20 lines, -21 lines	0 comments	Download
M	dart/lib/compiler/implementation/native_handler.dart	View	1	1 chunk	+10 lines, -9 lines	0 comments	Download
M	dart/lib/compiler/implementation/patch_parser.dart	View		1 chunk	+10 lines, -9 lines	0 comments	Download
M	dart/lib/compiler/implementation/resolution/members.dart	View		8 chunks	+10 lines, -10 lines	0 comments	Download
A	dart/lib/compiler/implementation/resolution/resolution.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/runtime_types.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/scannerlib.dart	View		1 chunk	+21 lines, -21 lines	0 comments	Download
M	dart/lib/compiler/implementation/ssa/ssa.dart	View		1 chunk	+32 lines, -29 lines	0 comments	Download
M	dart/lib/compiler/implementation/ssa/tracer.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	dart/lib/compiler/implementation/string_validator.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	dart/lib/compiler/implementation/types/concrete_types_inferrer.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/types/types.dart	View		1 chunk	+7 lines, -8 lines	0 comments	Download
M	dart/lib/compiler/implementation/universe/universe.dart	View		1 chunk	+12 lines, -13 lines	0 comments	Download
M	dart/lib/compiler/samples/leap/leap.dart	View		1 chunk	+12 lines, -12 lines	0 comments	Download
M	dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View		1 chunk	+21 lines, -19 lines	0 comments	Download
M	dart/tests/compiler/dart2js/backend_htype_list_test.dart	View		1 chunk	+7 lines, -9 lines	0 comments	Download
M	dart/tests/compiler/dart2js/compiler_helper.dart	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	dart/tests/compiler/dart2js/compiler_test.dart	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	dart/tests/compiler/dart2js/cpa_inference_test.dart	View		1 chunk	+15 lines, -11 lines	0 comments	Download
M	dart/tests/compiler/dart2js/dart_backend_test.dart	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	dart/tests/compiler/dart2js/metadata_test.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js/mock_compiler.dart	View		1 chunk	+12 lines, -11 lines	0 comments	Download
M	dart/tests/compiler/dart2js/parser_helper.dart	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	dart/tests/compiler/dart2js/patch_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	dart/tests/compiler/dart2js/resolver_test.dart	View		1 chunk	+11 lines, -11 lines	0 comments	Download
M	dart/tests/compiler/dart2js/source_mapping_test.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js/type_checker_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	dart/tests/compiler/dart2js/type_equals_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	dart/tests/compiler/dart2js/unparser2_test.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js/value_range2_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/11184046/diff/1/dart/lib/compiler/implementation/elements/elements.dart File dart/lib/compiler/implementation/elements/elements.dart (left): https://codereview.chromium.org/11184046/diff/1/dart/lib/compiler/implementation/elements/elements.dart#oldcode13 dart/lib/compiler/implementation/elements/elements.dart:13: #import('../leg.dart'); // TODO(karlklose): we only need type. And then ...

8 years, 2 months ago (2012-10-18 18:38:17 UTC) #1

kasperl

LGTM! Thanks for doing this, Peter. https://codereview.chromium.org/11184046/diff/1/dart/lib/compiler/implementation/native_handler.dart File dart/lib/compiler/implementation/native_handler.dart (right): https://codereview.chromium.org/11184046/diff/1/dart/lib/compiler/implementation/native_handler.dart#newcode5 dart/lib/compiler/implementation/native_handler.dart:5: library native_handler; What ...

8 years, 2 months ago (2012-10-19 06:04:44 UTC) #2

ahe

8 years, 2 months ago (2012-10-19 06:19:27 UTC) #3

Thank you, Kasperl!

https://codereview.chromium.org/11184046/diff/1/dart/lib/compiler/implementat...
File dart/lib/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11184046/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/native_handler.dart:5: library native_handler;
On 2012/10/19 06:04:44, kasperl wrote:
> What kind of names are you going for in libraries? camelCase or hacker_style?

No style, just this simple rule "use the existing string if possible". In this
case, that lead to a warning that I cannot reproduce. So I'm restoring the
orignal string.

Expand Messages | Collapse Messages