Support new named arguments.

Support new named arguments.

R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=13721

[Anton Muhin, 2012-10-16 18:48:21]

This change should make all the html test pass with the flag which enforces new
optionals/named.

But it's ugly, still, I'd suggest to submit it and to start to cleanup the mess
with the follow up CLs.

Obviously, things like .observe now just horrible: I think we should have named
arguments for all Dictionaries we expand.

Also named arguments for type array methods look natural.

So I'd suggest to introduce a special list of methods for which we retain IDL
names.

Thoughts?

[Emily Fortuna, 2012-10-16 19:51:17]

anton, plan sgtm. a few suggestions

https://codereview.chromium.org/11184007/diff/1/tests/html/canvas_pixel_array...
File tests/html/canvas_pixel_array_type_alias_test.dart (right):

https://codereview.chromium.org/11184007/diff/1/tests/html/canvas_pixel_array...
tests/html/canvas_pixel_array_type_alias_test.dart:37: expect(data,
hasLength(40000));
question: why does this test use the old style of specifying "expectations"?
What about Expect.equals(data, hasLength(4000)) and Expect.isTrue?

https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_2_tes...
File tests/html/typed_arrays_2_test.dart (right):

https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_2_tes...
tests/html/typed_arrays_2_test.dart:40: // OPTIONALS a2 = new
Uint32Array.fromBuffer(a1.buffer, length: 30, byteOffset: 456);
80 char, here and mutation_observer.

https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_datav...
File tests/html/typed_arrays_dataview_test.dart (right):

https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_datav...
tests/html/typed_arrays_dataview_test.dart:74: // OPTIONALS
expect(dv.getUint32(0, littleEndian: true), equals(0xFF030000));
80 char..

[blois, 2012-10-16 20:35:23]

Agree that we need to work on adding back named params- the File stuff looks
pretty ugly without it as well!

lgtm though.

On 2012/10/16 19:51:17, Emily Fortuna wrote:
> anton, plan sgtm. a few suggestions
> 
>
https://codereview.chromium.org/11184007/diff/1/tests/html/canvas_pixel_array...
> File tests/html/canvas_pixel_array_type_alias_test.dart (right):
> 
>
https://codereview.chromium.org/11184007/diff/1/tests/html/canvas_pixel_array...
> tests/html/canvas_pixel_array_type_alias_test.dart:37: expect(data,
> hasLength(40000));
> question: why does this test use the old style of specifying "expectations"?
> What about Expect.equals(data, hasLength(4000)) and Expect.isTrue?
> 
>
https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_2_tes...
> File tests/html/typed_arrays_2_test.dart (right):
> 
>
https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_2_tes...
> tests/html/typed_arrays_2_test.dart:40: // OPTIONALS a2 = new
> Uint32Array.fromBuffer(a1.buffer, length: 30, byteOffset: 456);
> 80 char, here and mutation_observer.
> 
>
https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_datav...
> File tests/html/typed_arrays_dataview_test.dart (right):
> 
>
https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_datav...
> tests/html/typed_arrays_dataview_test.dart:74: // OPTIONALS
> expect(dv.getUint32(0, littleEndian: true), equals(0xFF030000));
> 80 char..

[Anton Muhin, 2012-10-17 09:13:37]

Thanks a lot for review, submitted

https://codereview.chromium.org/11184007/diff/1/tests/html/canvas_pixel_array...
File tests/html/canvas_pixel_array_type_alias_test.dart (right):

https://codereview.chromium.org/11184007/diff/1/tests/html/canvas_pixel_array...
tests/html/canvas_pixel_array_type_alias_test.dart:37: expect(data,
hasLength(40000));
On 2012/10/16 19:51:17, Emily Fortuna wrote:
> question: why does this test use the old style of specifying "expectations"?
> What about Expect.equals(data, hasLength(4000)) and Expect.isTrue?

Seems reasonable, but let address that in a separate CL

https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_2_tes...
File tests/html/typed_arrays_2_test.dart (right):

https://codereview.chromium.org/11184007/diff/1/tests/html/typed_arrays_2_tes...
tests/html/typed_arrays_2_test.dart:40: // OPTIONALS a2 = new
Uint32Array.fromBuffer(a1.buffer, length: 30, byteOffset: 456);
On 2012/10/16 19:51:17, Emily Fortuna wrote:
> 80 char, here and mutation_observer.

Those optionals lines should go away soon, let's keep the delta to the minimum