Issue 11183053: Remove VariableScope, Scope.lexicalLookup and Scope.inStaticContext

Issue 11183053: Remove VariableScope, Scope.lexicalLookup and Scope.inStaticContext (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, aam-me

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove VariableScope, Scope.lexicalLookup and Scope.inStaticContext Committed: https://code.google.com/p/dart/source/detail?r=13810

Patch Set 2 : Updated cf. comments #

Total comments: 4

Patch Set 3 : Updated cf. comment #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -66 lines)			Patch
M	lib/compiler/implementation/elements/elements.dart	View	1 2	2 chunks	+0 lines, -22 lines	0 comments	Download
M	lib/compiler/implementation/resolution/members.dart	View	1 2	8 chunks	+10 lines, -41 lines	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

Not sure about the compile-time error when accessing a type variable from static scope. Otherwise ...

8 years, 2 months ago (2012-10-18 08:29:45 UTC) #2

Johnni Winther

https://codereview.chromium.org/11183053/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://codereview.chromium.org/11183053/diff/1/lib/compiler/implementation/resolver.dart#newcode2950 lib/compiler/implementation/resolver.dart:2950: Element e = resolver.lookup(node, name); Adding a TODO since ...

8 years, 2 months ago (2012-10-18 08:48:11 UTC) #3

ahe

LGTM! https://codereview.chromium.org/11183053/diff/5001/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://codereview.chromium.org/11183053/diff/5001/lib/compiler/implementation/resolver.dart#newcode2953 lib/compiler/implementation/resolver.dart:2953: // TODO(johnniwinther): Change errors to warnings, cf. 11.11.1. ...

8 years, 2 months ago (2012-10-18 11:18:18 UTC) #4

Johnni Winther

8 years, 2 months ago (2012-10-19 08:34:07 UTC) #5

https://codereview.chromium.org/11183053/diff/5001/lib/compiler/implementatio...
File lib/compiler/implementation/resolver.dart (right):

https://codereview.chromium.org/11183053/diff/5001/lib/compiler/implementatio...
lib/compiler/implementation/resolver.dart:2953: // TODO(johnniwinther): Change
errors to warnings, cf. 11.11.1.
On 2012/10/18 11:18:18, ahe wrote:
> This comment doesn't apply to the type variable case below, right?

It does. Only if the type variable is accessed from a static member is it an
error, which is something we should handle in the TypeResolver, I think.

https://codereview.chromium.org/11183053/diff/5001/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11183053/diff/5001/tests/language/language_da...
tests/language/language_dart2js.status:81: new_expression_type_args_test/02:
Fail # Missing test for type variable within static member
On 2012/10/18 11:18:18, ahe wrote:
> This comment is also confusing in this context.

Changed.

Expand Messages | Collapse Messages