Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 11183038: Unflake-ify xhr_cross_origin_test. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna
Modified:
8 years, 2 months ago
Reviewers:
vsm, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Unflake-ify xhr_cross_origin_test. Committed: https://code.google.com/p/dart/source/detail?r=13758

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tests/html/html.status View 1 chunk +0 lines, -2 lines 0 comments Download
A tests/html/xhr_cross_origin_data.txt View 1 chunk +1 line, -0 lines 1 comment Download
M tests/html/xhr_cross_origin_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
Fix for http://code.google.com/p/dart/issues/detail?id=5645. Basically I transferred the data that we were pulling from an external ...
8 years, 2 months ago (2012-10-17 20:30:15 UTC) #1
ahe
8 years, 2 months ago (2012-10-17 20:34:34 UTC) #2
Awesome. You also fixed a critical bug in the original code: long lines ;-)

LGTM!

Powered by Google App Engine
This is Rietveld 408576698