Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1118123004: one-line api doc comment for dart:typed_data (Closed)

Created:
5 years, 7 months ago by sethladd
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

one-line api doc comment for dart:typed_data BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45516

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweaks from review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M sdk/lib/typed_data/typed_data.dart View 1 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
sethladd
suggestions welcome.
5 years, 7 months ago (2015-05-04 23:28:20 UTC) #2
Cutch
LGTM with suggestions https://codereview.chromium.org/1118123004/diff/1/sdk/lib/typed_data/typed_data.dart File sdk/lib/typed_data/typed_data.dart (right): https://codereview.chromium.org/1118123004/diff/1/sdk/lib/typed_data/typed_data.dart#newcode6 sdk/lib/typed_data/typed_data.dart:6: /// such as lists of 16-bit ...
5 years, 7 months ago (2015-05-04 23:36:22 UTC) #3
sethladd
Committed patchset #2 (id:20001) manually as 45516 (presubmit successful).
5 years, 7 months ago (2015-05-05 00:18:51 UTC) #4
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-05 05:11:24 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1118123004/diff/20001/sdk/lib/typed_data/type...
File sdk/lib/typed_data/typed_data.dart (right):

https://codereview.chromium.org/1118123004/diff/20001/sdk/lib/typed_data/type...
sdk/lib/typed_data/typed_data.dart:6: /// (for example, unsigned 8 byte
integers) and SIMD numeric types.
Use /** comments for consistency with the rest of the file.

Powered by Google App Engine
This is Rietveld 408576698