Constructors are handled correct in dartdoc.

Constructors are handled correct in dartdoc. 
Dartdoc can show private types and members. 
Object members are not inherited by default.

Committed: https://code.google.com/p/dart/source/detail?r=13728

[Lasse Reichstein Nielsen, 2012-10-17 10:27:50]

lgtm

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart
File pkg/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1046: return;
Returns inside parameter functions are hard to read (indentation doesn't tell me
that I'm in a local function).
Can it be rewritten to avoid returns?
E.g. 
 if ((showPrivate || !member.isPrivate) &&
     (type == host || 
      (!member.isPrivate && !member.isConstructor))) {
   // body
 }

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1073: if (member.surroundingDeclaration === host) {
Just use ==, unless there is a compelling reason not to.

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1107: staticGetters, staticSetters, false);
"false" is a magic constant. Make it a named parameter.

[Johnni Winther, 2012-10-17 10:47:08]

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart
File pkg/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1046: return;
On 2012/10/17 10:27:50, Lasse Reichstein Nielsen wrote:
> Returns inside parameter functions are hard to read (indentation doesn't tell
me
> that I'm in a local function).
> Can it be rewritten to avoid returns?
> E.g. 
>  if ((showPrivate || !member.isPrivate) &&
>      (type == host || 
>       (!member.isPrivate && !member.isConstructor))) {
>    // body
>  }

Changed to use flag instead.

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1073: if (member.surroundingDeclaration === host) {
On 2012/10/17 10:27:50, Lasse Reichstein Nielsen wrote:
> Just use ==, unless there is a compelling reason not to.

Done.

https://codereview.chromium.org/11176004/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1107: staticGetters, staticSetters, false);
On 2012/10/17 10:27:50, Lasse Reichstein Nielsen wrote:
> "false" is a magic constant. Make it a named parameter.

Done.