Issue 11175055: As of now reason is a positional argument of expect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11175055: As of now reason is a positional argument of expect. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

As of now reason is a positional argument of expect. Adjust the test to the harsh reality. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=13942

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tests/html/canvas_pixel_array_type_alias_test.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://codereview.chromium.org/11175055/diff/1/tests/html/canvas_pixel_array_type_alias_test.dart File tests/html/canvas_pixel_array_type_alias_test.dart (right): https://codereview.chromium.org/11175055/diff/1/tests/html/canvas_pixel_array_type_alias_test.dart#newcode34 tests/html/canvas_pixel_array_type_alias_test.dart:34: expect(confuseType(data) is Uint8ClampedArray, isTrue, : 'canvas array type'); Looks ...

8 years, 2 months ago (2012-10-23 09:54:10 UTC) #2

Anton Muhin

8 years, 2 months ago (2012-10-23 10:07:31 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 11175055: As of now reason is a positional argument of expect. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages