Add sessions to HttpServer.

Add sessions to HttpServer.

A session is started when HttpRequest.getSession() is called. The
session will then be added to the session manager. The session manager
then controls timeouts.

The session id is create by using the a crypto-random sequence of 16
bytes. These are extracted by using /dev/urandom on posix and
CryptGenRandom on windows.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13870

[Anders Johnsen, 2012-10-22 09:53:41]

Oops, I deleted the other one(??????)

[Søren Gjesse, 2012-10-22 11:13:02]

LGTM with comments

http://codereview.chromium.org/11175030/diff/1/runtime/bin/crypto.cc
File runtime/bin/crypto.cc (right):

http://codereview.chromium.org/11175030/diff/1/runtime/bin/crypto.cc#newcode19
runtime/bin/crypto.cc:19: uint8_t* buffer = new uint8_t[count];
Shouldn't we check for NULL here?

http://codereview.chromium.org/11175030/diff/1/runtime/bin/crypto.cc#newcode22
runtime/bin/crypto.cc:22: Dart_Handle error = Dart_NewString("Failed to get
random bytes.");
Maybe this should be an OSError is errno/GetLastError can provide additional
information.

http://codereview.chromium.org/11175030/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

http://codereview.chromium.org/11175030/diff/1/runtime/bin/http.dart#newcode596
runtime/bin/http.dart:596: HttpSession session([initSessions(HttpSession
session)]);
initSessions -> initSession (or maybe just init).

http://codereview.chromium.org/11175030/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

http://codereview.chromium.org/11175030/diff/1/runtime/bin/http_impl.dart#new...
runtime/bin/http_impl.dart:877: // Map to session if exists.
There is a pay for non-use here. We run through the cookies even if sessions are
not used. Maybe this should be lazy, but of cause the markSeen call will then
only be used if the session is actually retrieved.

[Anders Johnsen, 2012-10-22 12:18:57]

Fixed, let me know if it's still looking good! :)

https://codereview.chromium.org/11175030/diff/1/runtime/bin/crypto.cc
File runtime/bin/crypto.cc (right):

https://codereview.chromium.org/11175030/diff/1/runtime/bin/crypto.cc#newcode19
runtime/bin/crypto.cc:19: uint8_t* buffer = new uint8_t[count];
On 2012/10/22 11:13:02, Søren Gjesse wrote:
> Shouldn't we check for NULL here?

Done.

https://codereview.chromium.org/11175030/diff/1/runtime/bin/crypto.cc#newcode22
runtime/bin/crypto.cc:22: Dart_Handle error = Dart_NewString("Failed to get
random bytes.");
On 2012/10/22 11:13:02, Søren Gjesse wrote:
> Maybe this should be an OSError is errno/GetLastError can provide additional
> information.

Done.

https://codereview.chromium.org/11175030/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://codereview.chromium.org/11175030/diff/1/runtime/bin/http.dart#newcode596
runtime/bin/http.dart:596: HttpSession session([initSessions(HttpSession
session)]);
On 2012/10/22 11:13:02, Søren Gjesse wrote:
> initSessions -> initSession (or maybe just init).

Done.

https://codereview.chromium.org/11175030/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://codereview.chromium.org/11175030/diff/1/runtime/bin/http_impl.dart#ne...
runtime/bin/http_impl.dart:877: // Map to session if exists.
On 2012/10/22 11:13:02, Søren Gjesse wrote:
> There is a pay for non-use here. We run through the cookies even if sessions
are
> not used. Maybe this should be lazy, but of cause the markSeen call will then
> only be used if the session is actually retrieved.

I've changed so that we check the server if sessions are initialized.

[Søren Gjesse, 2012-10-22 12:56:27]

lgtm

http://codereview.chromium.org/11175030/diff/7001/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

http://codereview.chromium.org/11175030/diff/7001/runtime/bin/http_impl.dart#...
runtime/bin/http_impl.dart:877: if
(_httpConnection._server._sessionManagerInstance != null) {
Nice.