Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1117223002: dart2js: Inline across deferred output units if that leads to reduced size. (Closed)

Created:
5 years, 7 months ago by herhut
Modified:
5 years, 7 months ago
Reviewers:
floitsch, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Inline across deferred output units if that leads to reduced size. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45553

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Changed to not inline across deferred imports. #

Patch Set 4 : Clean up test. #

Total comments: 10

Patch Set 5 : Comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -31 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 1 2 3 4 1 chunk +14 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 3 4 3 chunks +18 lines, -8 lines 2 comments Download
A + tests/compiler/dart2js/deferred_inline_restrictions_test.dart View 1 2 3 4 2 chunks +59 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
herhut
5 years, 7 months ago (2015-05-01 09:48:49 UTC) #2
floitsch
https://codereview.chromium.org/1117223002/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (left): https://codereview.chromium.org/1117223002/diff/1/pkg/compiler/lib/src/ssa/builder.dart#oldcode1297 pkg/compiler/lib/src/ssa/builder.dart:1297: // it is to save space in the loading ...
5 years, 7 months ago (2015-05-04 23:32:58 UTC) #3
floitsch
https://codereview.chromium.org/1117223002/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1117223002/diff/1/pkg/compiler/lib/src/ssa/builder.dart#newcode1341 pkg/compiler/lib/src/ssa/builder.dart:1341: if (isCalledOnce(element)) { I guess we could inline empty ...
5 years, 7 months ago (2015-05-04 23:34:45 UTC) #4
herhut
PTAL https://codereview.chromium.org/1117223002/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (left): https://codereview.chromium.org/1117223002/diff/1/pkg/compiler/lib/src/ssa/builder.dart#oldcode1297 pkg/compiler/lib/src/ssa/builder.dart:1297: // it is to save space in the ...
5 years, 7 months ago (2015-05-05 14:19:12 UTC) #6
floitsch
LGTM! https://codereview.chromium.org/1117223002/diff/80001/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1117223002/diff/80001/pkg/compiler/lib/src/deferred_load.dart#newcode206 pkg/compiler/lib/src/deferred_load.dart:206: /// For example, if we have two deferred ...
5 years, 7 months ago (2015-05-05 17:58:16 UTC) #7
floitsch
LGTM!
5 years, 7 months ago (2015-05-05 17:58:16 UTC) #8
herhut
https://codereview.chromium.org/1117223002/diff/80001/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1117223002/diff/80001/pkg/compiler/lib/src/deferred_load.dart#newcode206 pkg/compiler/lib/src/deferred_load.dart:206: /// For example, if we have two deferred libraries ...
5 years, 7 months ago (2015-05-06 08:37:09 UTC) #9
herhut
Committed patchset #5 (id:100001) manually as 45553 (presubmit successful).
5 years, 7 months ago (2015-05-06 08:38:01 UTC) #10
sra1
https://chromiumcodereview.appspot.com/1117223002/diff/100001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/1117223002/diff/100001/pkg/compiler/lib/src/ssa/builder.dart#newcode1351 pkg/compiler/lib/src/ssa/builder.dart:1351: return InlineWeeder.canBeInlined(function, 1, true); Call doesNotContainCode below?
5 years, 7 months ago (2015-05-06 20:49:56 UTC) #12
herhut
5 years, 7 months ago (2015-05-26 14:26:29 UTC) #13
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1117223002/diff/100001/pkg/compiler/li...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/1117223002/diff/100001/pkg/compiler/li...
pkg/compiler/lib/src/ssa/builder.dart:1351: return
InlineWeeder.canBeInlined(function, 1, true);
On 2015/05/06 20:49:56, sra1 wrote:
> Call doesNotContainCode below?

Done in https://codereview.chromium.org/1159813002.

Powered by Google App Engine
This is Rietveld 408576698