More source utilities

More source utilities

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45492

[Brian Wilkerson, 2015-05-04 04:12:05]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-05-04 04:41:28]

LGTM

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/utilities/change_builder_dart.dart (right):

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:63: String
nameGroupName, DartType superclass}) {
The "nameGroupName" parameter is not used.

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:67:
write(Keyword.ABSTRACT.syntax);
I don't see why we need to use token literals.
We write "class ", " with ", " extends Object", " = " and ", " as a string
literals anyway.
I doubt that we are going to change lexemes for keywords and other tokens.

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:68: ;
Empty statement.

[Brian Wilkerson, 2015-05-04 15:03:38]

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/utilities/change_builder_dart.dart (right):

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:63: String
nameGroupName, DartType superclass}) {
Done

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:67:
write(Keyword.ABSTRACT.syntax);
True. Perhaps it's overkill, but it seemed cleaner to me.

https://codereview.chromium.org/1117183004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:68: ;
Removed

[Brian Wilkerson, 2015-05-04 15:04:08]

Committed patchset #1 (id:1) manually as 45492 (presubmit successful).