Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1117183002: Ignore synthetic tokens when search for AstNode. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Ignore synthetic tokens when search for AstNode. This fixes the exception you saw during 'Extract Local' refactoring. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -133 lines) Patch
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 38 chunks +81 lines, -131 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 7 months ago (2015-05-01 02:08:15 UTC) #1
scheglov
ping
5 years, 7 months ago (2015-05-03 05:14:53 UTC) #2
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-03 15:09:06 UTC) #3
scheglov
5 years, 7 months ago (2015-05-03 20:29:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698