Issue 1116593002: Issue 23337. Quick Fix for removing dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1116593002: Issue 23337. Quick Fix for removing dead code. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -0 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/fix.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	4 chunks	+37 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	1 chunk	+50 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Brian Wilkerson

LGTM, but this should also handle import directives at some point (perhaps a TODO comment).

5 years, 7 months ago (2015-04-29 04:49:36 UTC) #2

scheglov

On 2015/04/29 04:49:36, Brian Wilkerson wrote: > LGTM, but this should also handle import directives ...

5 years, 7 months ago (2015-04-29 04:51:25 UTC) #3

scheglov

5 years, 7 months ago (2015-04-29 04:52:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45447 (presubmit successful).