Issue 1116553002: Change default value of c_frame_pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1116553002: Change default value of c_frame_pointers (Closed)

Created:
5 years, 7 months ago by Cutch

Modified:
5 years, 7 months ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Change default value of c_frame_pointers BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45443

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/gyp/all.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 45443 (presubmit successful).

5 years, 7 months ago (2015-04-28 23:28:44 UTC) #4

Florian Schneider

dbc: What was the reason for this? Please add some info to the CL description.

5 years, 7 months ago (2015-05-11 14:11:40 UTC) #6

Cutch

5 years, 7 months ago (2015-05-11 14:13:59 UTC) #7

Message was sent while issue was closed.

On 2015/05/11 14:11:40, Florian Schneider wrote:
> dbc: What was the reason for this? Please add some info to the CL description.

This change allows us to use Observatory's profiler for native code.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages