Chromium Code Reviews

Issue 1116443002: Support future matchers and expectAsync in tearDowns. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest.git@master
Visibility:
Public.

Description

Support future matchers and expectAsync in tearDowns. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/e2ea40e970d5cab8a6151736d626e9a0e5c00679

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+199 lines, -38 lines)
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments
M lib/src/backend/invoker.dart View 7 chunks +42 lines, -37 lines 0 comments
A lib/src/backend/outstanding_callback_counter.dart View 1 chunk +42 lines, -0 lines 2 comments
M lib/src/utils.dart View 1 chunk +10 lines, -0 lines 0 comments
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments
M test/backend/invoker_test.dart View 2 chunks +99 lines, -0 lines 0 comments

Messages

Total messages: 5 (1 generated)
nweiz
5 years, 7 months ago (2015-04-28 18:34:30 UTC) #2
kevmoo
LGTM w/ a nit https://codereview.chromium.org/1116443002/diff/1/lib/src/backend/outstanding_callback_counter.dart File lib/src/backend/outstanding_callback_counter.dart (right): https://codereview.chromium.org/1116443002/diff/1/lib/src/backend/outstanding_callback_counter.dart#newcode15 lib/src/backend/outstanding_callback_counter.dart:15: var _count = 1; int!
5 years, 7 months ago (2015-04-28 18:44:49 UTC) #3
nweiz
https://codereview.chromium.org/1116443002/diff/1/lib/src/backend/outstanding_callback_counter.dart File lib/src/backend/outstanding_callback_counter.dart (right): https://codereview.chromium.org/1116443002/diff/1/lib/src/backend/outstanding_callback_counter.dart#newcode15 lib/src/backend/outstanding_callback_counter.dart:15: var _count = 1; On 2015/04/28 18:44:49, kevmoo wrote: ...
5 years, 7 months ago (2015-04-28 18:56:18 UTC) #4
nweiz
5 years, 7 months ago (2015-04-28 18:57:01 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e2ea40e970d5cab8a6151736d626e9a0e5c00679 (presubmit successful).

Powered by Google App Engine