Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 111643012: Partially implement LibraryMirror.topLevelMembers. (Closed)

Created:
7 years ago by rmacnak
Modified:
7 years ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Partially implement LibraryMirror.topLevelMembers. BUG=http://dartbug.com/14632 R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=31202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 chunk +25 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/synthetic_accessor_properties_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/lib/mirrors/toplevel_members_test.dart View 2 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
7 years ago (2013-12-17 00:16:38 UTC) #1
gbracha
tests lgtm
7 years ago (2013-12-17 00:26:21 UTC) #2
rmacnak
7 years ago (2013-12-17 00:32:10 UTC) #3
siva
lgtm
7 years ago (2013-12-17 17:17:48 UTC) #4
rmacnak
7 years ago (2013-12-17 19:20:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r31202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698