restructure internal request to implement CompletionRequest API,

restructure internal request to implement CompletionRequest API,
move performance tracking out of internal completion request,
and add resourceProvider to request

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45455

[danrubel, 2015-04-29 21:51:21]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-04-30 04:01:22]

LGTM! That was cleaner than I was fearing.

https://codereview.chromium.org/1115843003/diff/1/pkg/analysis_server/lib/com...
File pkg/analysis_server/lib/completion/completion_core.dart (right):

https://codereview.chromium.org/1115843003/diff/1/pkg/analysis_server/lib/com...
pkg/analysis_server/lib/completion/completion_core.dart:40: //CompletionResult
get previousResults;
I'm confused by this. If you're proposing that we drop the method, then we
should remove it. If you just can't implement it yet, perhaps it would be better
to leave it in the interface and implement it to throw an exception.

https://codereview.chromium.org/1115843003/diff/1/pkg/analysis_server/lib/com...
pkg/analysis_server/lib/completion/completion_core.dart:55: ResourceProvider get
provider;
The name 'provider' is fairly generic. Perhaps 'resourceProvider' to be
consistent with AnalysisServer (which I think will also end up being public API
at some point)?

[danrubel, 2015-04-30 05:03:11]

On 2015/04/30 04:01:22, Brian Wilkerson wrote:
> LGTM! That was cleaner than I was fearing.

This is step 1 of 4 or 5 more steps to convert existing functionality to the new
public API. Next is to implement DartCompletionRequest.

https://codereview.chromium.org/1115843003/diff/1/pkg/analysis_server/lib/com...
File pkg/analysis_server/lib/completion/completion_core.dart (right):

https://codereview.chromium.org/1115843003/diff/1/pkg/analysis_server/lib/com...
pkg/analysis_server/lib/completion/completion_core.dart:40: //CompletionResult
get previousResults;
On 2015/04/30 04:01:22, Brian Wilkerson wrote:
> I'm confused by this. If you're proposing that we drop the method, then we
> should remove it. If you just can't implement it yet, perhaps it would be
better
> to leave it in the interface and implement it to throw an exception.

I'm not sure so I commented it out. As mentioned above, this is step 1 of 4 or
5, so I'll clean it up as part of this process.

https://codereview.chromium.org/1115843003/diff/1/pkg/analysis_server/lib/com...
pkg/analysis_server/lib/completion/completion_core.dart:55: ResourceProvider get
provider;
On 2015/04/30 04:01:22, Brian Wilkerson wrote:
> The name 'provider' is fairly generic. Perhaps 'resourceProvider' to be
> consistent with AnalysisServer (which I think will also end up being public
API
> at some point)?

Good point. Renamed.

[danrubel, 2015-04-30 05:09:53]

Committed patchset #3 (id:40001) manually as 45455 (presubmit successful).