Add ConstantConstructor to ConstantExpression system.

Add ConstantConstructor to ConstantExpression system.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45681

[Johnni Winther, 2015-04-30 13:17:16]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[Johnni Winther, 2015-04-30 13:17:16]

Look in constants/expressions.dart first.

[karlklose, 2015-05-11 10:23:19]

LGTM.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/constructors.dart (right):

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/constructors.dart:43: final Map<FieldElement,
ConstantExpression> fieldMap = {};
Add type arguments to literals (here, below, Lines 106 and 107).

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/constructors.dart:60: internalError(node,
'Unhandled node $node (${node.runtimeType})');
We should avoid calling 'runtimeType' if we are only interested in the class. Is
'toString' not enough?

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/expressions.dart (left):

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:305: @override
Restore '@override'?

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/expressions.dart (right):

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:48: class Arguments {
This class should have a more specific name like, for example,
NormalizedArguments, MatchedArguments, ...

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:49: final
Map<dynamic/*int|String*/, ConstantExpression> defaultValues;
In the emitter code modell we used 'var /*Map|List*/' for this data-structure.

Maybe we should just use a list *and* a map in both places.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:101: final
ConstructedConstantExpression constructorInvocation;
'constructorInvocation' -> 'superConstructor[Invocation]'?

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:118: Arguments args = new
Arguments(defaultValues, callStructure, arguments);
Lines 118-127 could be shared with ll. 171-178 in
RedirectingGenerativeConstantConstructor.computeInstanceFields.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:136: sb.write("{'type': $type");
Do we have a JSON library that could do this conversion for us? Using a library
would also make it obvious that we want to produce JSON.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:196: final
ConstructedConstantExpression constructorInvocation;
'targetConstructorInvocation'?

[Johnni Winther, 2015-05-11 12:24:58]

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/constructors.dart (right):

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/constructors.dart:43: final Map<FieldElement,
ConstantExpression> fieldMap = {};
On 2015/05/11 10:23:18, karlklose wrote:
> Add type arguments to literals (here, below, Lines 106 and 107).

Done.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/constructors.dart:60: internalError(node,
'Unhandled node $node (${node.runtimeType})');
On 2015/05/11 10:23:18, karlklose wrote:
> We should avoid calling 'runtimeType' if we are only interested in the class.
Is
> 'toString' not enough?

toString unparses which is too imprecise. Will use toDebugString instead.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/expressions.dart (left):

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:305: @override
On 2015/05/11 10:23:19, karlklose wrote:
> Restore '@override'?

Done.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/expressions.dart (right):

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:48: class Arguments {
On 2015/05/11 10:23:18, karlklose wrote:
> This class should have a more specific name like, for example,
> NormalizedArguments, MatchedArguments, ...

NormalizedArguments it is.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:49: final
Map<dynamic/*int|String*/, ConstantExpression> defaultValues;
On 2015/05/11 10:23:18, karlklose wrote:
> In the emitter code modell we used 'var /*Map|List*/' for this data-structure.
> 
> Maybe we should just use a list *and* a map in both places.

A list is annoying is the indices are absolute and therefore might not start at
0.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:101: final
ConstructedConstantExpression constructorInvocation;
On 2015/05/11 10:23:19, karlklose wrote:
> 'constructorInvocation' -> 'superConstructor[Invocation]'?

Done.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:118: Arguments args = new
Arguments(defaultValues, callStructure, arguments);
On 2015/05/11 10:23:19, karlklose wrote:
> Lines 118-127 could be shared with ll. 171-178 in
> RedirectingGenerativeConstantConstructor.computeInstanceFields.

Done.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:136: sb.write("{'type': $type");
On 2015/05/11 10:23:19, karlklose wrote:
> Do we have a JSON library that could do this conversion for us? Using a
library
> would also make it obvious that we want to produce JSON.

JSON isn't imported, just wanted it readable.

https://codereview.chromium.org/1115183002/diff/40001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:196: final
ConstructedConstantExpression constructorInvocation;
On 2015/05/11 10:23:19, karlklose wrote:
> 'targetConstructorInvocation'?

Done.

[Johnni Winther, 2015-05-11 12:47:25]

Committed patchset #4 (id:60001) manually as 45681 (presubmit successful).