Issue 11151026: Download to a temp dir and rename on success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11151026: Download to a temp dir and rename on success. (Closed)

Created:
8 years, 2 months ago by Bob Nystrom

Modified:
8 years, 2 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Download to a temp dir and rename on success. This prevents ghost packages ending up in your pub cache if a download fails. Also added some more output during installation so you can see what's happening. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13666

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to review. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
M	utils/pub/hosted_source.dart	View		1 chunk	+13 lines, -12 lines	0 comments	Download
M	utils/pub/io.dart	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	utils/pub/version_solver.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/tests/pub/update/pub_update_test.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://chromiumcodereview.appspot.com/11151026/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://chromiumcodereview.appspot.com/11151026/diff/1/utils/pub/io.dart#newcode290 utils/pub/io.dart:290: return from.rename(to); Style nit: this would be cleaner ...

8 years, 2 months ago (2012-10-15 20:56:27 UTC) #2

Bob Nystrom

8 years, 2 months ago (2012-10-15 20:59:23 UTC) #3

https://chromiumcodereview.appspot.com/11151026/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/11151026/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:290: return from.rename(to);
On 2012/10/15 20:56:27, nweiz wrote:
> Style nit: this would be cleaner as a one-liner.

Done.

Expand Messages | Collapse Messages