Issue 11150023: Change the editor build to use the latest changed svn revision and not the global svn revision.

Issue 11150023: Change the editor build to use the latest changed svn revision and not the global svn revision. (Closed)

Created:
8 years, 2 months ago by devoncarew

Modified:
8 years, 2 months ago

Reviewers:
dgrove, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change the editor build to use the latest changed svn revision and not the global svn revision. Committed: https://code.google.com/p/dart/source/detail?r=13665

Patch Set 1 #

Total comments: 4

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	client/tools/buildbot_annotated_steps.py	View		2 chunks	+31 lines, -0 lines	4 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danrubel

lgtm https://chromiumcodereview.appspot.com/11150023/diff/1/client/tools/buildbot_annotated_steps.py File client/tools/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/11150023/diff/1/client/tools/buildbot_annotated_steps.py#newcode99 client/tools/buildbot_annotated_steps.py:99: # get the latest changed revision from the ...

8 years, 2 months ago (2012-10-15 20:49:34 UTC) #2

devoncarew

https://chromiumcodereview.appspot.com/11150023/diff/1/client/tools/buildbot_annotated_steps.py File client/tools/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/11150023/diff/1/client/tools/buildbot_annotated_steps.py#newcode99 client/tools/buildbot_annotated_steps.py:99: # get the latest changed revision from the current ...

8 years, 2 months ago (2012-10-15 20:55:28 UTC) #3

dgrove

lgtm https://codereview.chromium.org/11150023/diff/1/client/tools/buildbot_annotated_steps.py File client/tools/buildbot_annotated_steps.py (right): https://codereview.chromium.org/11150023/diff/1/client/tools/buildbot_annotated_steps.py#newcode186 client/tools/buildbot_annotated_steps.py:186: print 'main' is this leftover debugging?

8 years, 2 months ago (2012-10-15 21:02:12 UTC) #4

devoncarew

8 years, 2 months ago (2012-10-15 21:03:44 UTC) #5

https://codereview.chromium.org/11150023/diff/1/client/tools/buildbot_annotat...
File client/tools/buildbot_annotated_steps.py (right):

https://codereview.chromium.org/11150023/diff/1/client/tools/buildbot_annotat...
client/tools/buildbot_annotated_steps.py:186: print 'main'
On 2012/10/15 21:02:12, dgrove wrote:
> is this leftover debugging?

It was in there already - doesn't seem to add a lot of value though.

Expand Messages | Collapse Messages