Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 11146022: Put a nasty sleep() on Windows. (Closed)

Created:
8 years, 2 months ago by Bob Nystrom
Modified:
8 years, 2 months ago
Reviewers:
nweiz, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Put a nasty sleep() on Windows. We get "file in use" errors between downloading and extracting archives, so sleep for a bit. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13668

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M utils/pub/io.dart View 3 chunks +8 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
I apologize for this patch.
8 years, 2 months ago (2012-10-15 21:23:34 UTC) #1
nweiz
lgtm
8 years, 2 months ago (2012-10-15 21:26:46 UTC) #2
kasperl
https://chromiumcodereview.appspot.com/11146022/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://chromiumcodereview.appspot.com/11146022/diff/1/utils/pub/io.dart#newcode689 utils/pub/io.dart:689: // TODO(rnystrom): Hack. We get intermittent "file already in ...
8 years, 2 months ago (2012-10-16 05:44:46 UTC) #3
Bob Nystrom
8 years, 2 months ago (2012-10-16 14:03:49 UTC) #4
On 2012/10/16 05:44:46, kasperl wrote:
> https://chromiumcodereview.appspot.com/11146022/diff/1/utils/pub/io.dart
> File utils/pub/io.dart (right):
> 
>
https://chromiumcodereview.appspot.com/11146022/diff/1/utils/pub/io.dart#newc...
> utils/pub/io.dart:689: // TODO(rnystrom): Hack. We get intermittent "file
> already in use" errors.
> This smells like a dart:io issue. Did you file a bug report already?

Yup: http://code.google.com/p/dart/issues/detail?id=5910

I emailed Mads a couple of weeks ago about the issues I've been seeing too.

Powered by Google App Engine
This is Rietveld 408576698