Issue 11144021: Fix crashes in intrinsified float32/float64 array setters when attempting to store a Smi. Added tes…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11144021: Fix crashes in intrinsified float32/float64 array setters when attempting to store a Smi. Added tes… (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, john_johnmccutchan.com

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix crashes in intrinsified float32/float64 array setters when attempting to store a Smi. Added tests. Committed: https://code.google.com/p/dart/source/detail?r=13664

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -4 lines)			Patch
M	runtime/vm/intrinsifier_ia32.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	tests/standalone/float_array_test.dart	View	1 2 3	3 chunks	+25 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Cutch

On 2012/10/15 18:48:01, srdjan wrote: LGTM. What does CompareClassId not work in the case of ...

8 years, 2 months ago (2012-10-15 19:43:54 UTC) #2

srdjan

On 2012/10/15 19:43:54, Cutch wrote: > On 2012/10/15 18:48:01, srdjan wrote: > > LGTM. What ...

8 years, 2 months ago (2012-10-15 19:45:58 UTC) #3

LGTM