Make argument of List.sort optional with default Comparable.compare.

Make argument of List.sort optional with default Comparable.compare.

BUG=1235
Committed: https://code.google.com/p/dart/source/detail?r=13718

[Johnni Winther, 2012-10-15 10:46:43]

lgtm

[ngeoffray, 2012-10-15 14:17:11]

https://codereview.chromium.org/11144016/diff/1/lib/compiler/implementation/l...
File lib/compiler/implementation/lib/interceptors.dart (right):

https://codereview.chromium.org/11144016/diff/1/lib/compiler/implementation/l...
lib/compiler/implementation/lib/interceptors.dart:367: sort$1(receiver, compare)
{
Why can't you have just one function with an optional parameter? Does that not
work with how we handle itnerceptors in the compiler? Is it easy to fix? Can you
add a TODO?

https://codereview.chromium.org/11144016/diff/1/tests/corelib/list_sort_test....
File tests/corelib/list_sort_test.dart (right):

https://codereview.chromium.org/11144016/diff/1/tests/corelib/list_sort_test....
tests/corelib/list_sort_test.dart:14: new SortHelper((list)=>list.sort(),
compare).run();
spaces around the '=>'

[sra1, 2012-10-16 05:58:04]

I would suggest that also passing a key would be more versatile:
http://code.google.com/p/dart/issues/detail?id=1235#c1

[Lasse Reichstein Nielsen, 2012-10-17 07:37:28]

Deciding how to sort should be done by the comparator function, not the sort
function. The sort function has no notion of "key".

https://codereview.chromium.org/11144016/diff/1/lib/compiler/implementation/l...
File lib/compiler/implementation/lib/interceptors.dart (right):

https://codereview.chromium.org/11144016/diff/1/lib/compiler/implementation/l...
lib/compiler/implementation/lib/interceptors.dart:367: sort$1(receiver, compare)
{
I don't think it works with how we handle receivers (it was my first attempt,
and q.v. lastIndexOf). I have no idea how easy it is to fix. I'll add a TODO for
you.

We really should be doing interceptors differently, preferably by generating
dispatch methods from the individual specialized methods, to avoid duplicated
code (and to make method extraction work for all methods).

https://codereview.chromium.org/11144016/diff/1/tests/corelib/list_sort_test....
File tests/corelib/list_sort_test.dart (right):

https://codereview.chromium.org/11144016/diff/1/tests/corelib/list_sort_test....
tests/corelib/list_sort_test.dart:14: new SortHelper((list)=>list.sort(),
compare).run();
Done.