Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11142015: update hello, world sample and remove slider (Closed)

Created:
8 years, 2 months ago by sethladd
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

also ignore ds_store remove unwanted file update the hello sample BUG= Committed: https://code.google.com/p/dart/source/detail?r=13711

Patch Set 1 #

Patch Set 2 : remove old sample that used ui lib code #

Total comments: 3

Patch Set 3 : update copyright date #

Patch Set 4 : remove slider from editor plugins #

Total comments: 1

Patch Set 5 : after merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -181 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/samples/slider.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/samples/slider.xml View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M samples/hi/hi.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M samples/hi/hi.html View 1 chunk +2 lines, -2 lines 0 comments Download
D samples/slider/README View 1 1 chunk +0 lines, -23 lines 0 comments Download
D samples/slider/slider_sample.css View 1 1 chunk +0 lines, -70 lines 0 comments Download
D samples/slider/slider_sample.dart View 1 1 chunk +0 lines, -42 lines 0 comments Download
D samples/slider/slider_sample.html View 1 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sethladd
PTAL, thanks!
8 years, 2 months ago (2012-10-15 06:30:46 UTC) #1
devoncarew
lgtm https://codereview.chromium.org/11142015/diff/3001/.gitignore File .gitignore (right): https://codereview.chromium.org/11142015/diff/3001/.gitignore#newcode60 .gitignore:60: .children You could also safely delete the .children ...
8 years, 2 months ago (2012-10-15 13:07:47 UTC) #2
sethladd
https://codereview.chromium.org/11142015/diff/3001/samples/hi/hi.dart File samples/hi/hi.dart (right): https://codereview.chromium.org/11142015/diff/3001/samples/hi/hi.dart#newcode1 samples/hi/hi.dart:1: // Copyright (c) 2011, the Dart project authors. Please ...
8 years, 2 months ago (2012-10-15 15:52:56 UTC) #3
Jennifer Messerly
On 2012/10/15 15:52:56, sethladd wrote: > https://codereview.chromium.org/11142015/diff/3001/samples/hi/hi.dart > File samples/hi/hi.dart (right): > > https://codereview.chromium.org/11142015/diff/3001/samples/hi/hi.dart#newcode1 > ...
8 years, 2 months ago (2012-10-15 17:52:05 UTC) #4
sethladd
removed slider from eclipse samples
8 years, 2 months ago (2012-10-15 19:23:36 UTC) #5
Jennifer Messerly
8 years, 2 months ago (2012-10-15 20:42:24 UTC) #6 
lgtm

https://codereview.chromium.org/11142015/diff/10001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/11142015/diff/10001/.gitignore#newcode71
.gitignore:71: .DS_Store
fyi: ideally you can run "svn ignore" on that file, and then use the "git svn
create-ignore" so both SVN and GIT know about the ignore.

Powered by Google App Engine
This is Rietveld 408576698