Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 11141020: Fix bug 5002: (Closed)

Created:
8 years, 2 months ago by Ivan Posva
Modified:
8 years, 2 months ago
Reviewers:
ricow1, turnidge, kasperl
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix bug 5002: - Add the necessary Dart_EnterScope/Dart_ExitScope calls to the mirror native code. Committed: https://code.google.com/p/dart/source/detail?r=13648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M runtime/lib/mirrors.cc View 6 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
8 years, 2 months ago (2012-10-15 07:58:15 UTC) #1
kasperl
LGTM.
8 years, 2 months ago (2012-10-15 07:59:18 UTC) #2
ricow1
8 years, 2 months ago (2012-10-15 08:00:59 UTC) #3
LGTM, I assume this is like v8 handle scopes?

Powered by Google App Engine
This is Rietveld 408576698