Issue 11138028: Change return type to w3c standard of void for AudioBufferCallback.

Issue 11138028: Change return type to w3c standard of void for AudioBufferCallback. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin, podivilov, blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change return types of Callbacks to w3c standard of void Committed: https://code.google.com/p/dart/source/detail?r=13795

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -67 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		25 chunks	+29 lines, -29 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		25 chunks	+29 lines, -29 lines	0 comments	Download
M	lib/html/idl/dart/dart.idl	View	1 2 3	1 chunk	+0 lines, -7 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Fix for http://code.google.com/p/dart/issues/detail?id=5464

8 years, 2 months ago (2012-10-15 23:55:13 UTC) #1

Anton Muhin

DBC https://codereview.chromium.org/11138028/diff/1/lib/html/idl/dart/dart.idl File lib/html/idl/dart/dart.idl (right): https://codereview.chromium.org/11138028/diff/1/lib/html/idl/dart/dart.idl#newcode399 lib/html/idl/dart/dart.idl:399: [Suppressed] boolean handleEvent(in AudioBuffer audioBuffer); just a thought: ...

8 years, 2 months ago (2012-10-16 09:41:09 UTC) #3

podivilov

https://codereview.chromium.org/11138028/diff/1/lib/html/idl/dart/dart.idl File lib/html/idl/dart/dart.idl (right): https://codereview.chromium.org/11138028/diff/1/lib/html/idl/dart/dart.idl#newcode399 lib/html/idl/dart/dart.idl:399: [Suppressed] boolean handleEvent(in AudioBuffer audioBuffer); On 2012/10/16 09:41:09, Anton ...

8 years, 2 months ago (2012-10-16 11:45:42 UTC) #4

Emily Fortuna

Pete, PTAL? Now all the callbacks proper return void.

8 years, 2 months ago (2012-10-17 18:29:18 UTC) #5

Anton Muhin

8 years, 2 months ago (2012-10-18 09:59:16 UTC) #7

Overall, I don't think you need to tweak Dartium part at all.  If you'd like, I
can patch candidate CL in and check it builds fine w/ Dartium.

https://codereview.chromium.org/11138028/diff/13001/lib/html/scripts/systemht...
File lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11138028/diff/13001/lib/html/scripts/systemht...
lib/html/scripts/systemhtml.py:219: info = AnalyzeOperation(self._interface,
handlers)
nit: you can move this line below and maybe even merge into
self._backend.GenerateCallback

https://codereview.chromium.org/11138028/diff/13001/lib/html/scripts/systemna...
File lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/11138028/diff/13001/lib/html/scripts/systemna...
lib/html/scripts/systemnative.py:55: '    virtual void
handleEvent($PARAMETERS);\n',
that's wrong: handleEvent in WebKit should return bool.  I mean in C++, not in
Dart, of course.

https://codereview.chromium.org/11138028/diff/13001/lib/html/scripts/systemna...
lib/html/scripts/systemnative.py:67: 'void
$CLASS_NAME::handleEvent($PARAMETERS)\n'
ditto

Expand Messages | Collapse Messages