Issue 1113363004: Cache pubspecs when HostedSource.getVersions is called.

Issue 1113363004: Cache pubspecs when HostedSource.getVersions is called. (Closed)

Created:
5 years, 7 months ago by nweiz

Modified:
5 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Cache pubspecs when HostedSource.getVersions is called. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=45571

Patch Set 3 : Code review changes #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -106 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/command/cache_add.dart	View	1	2 chunks	+28 lines, -30 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/solver/version_solver.dart	View	1 2	2 chunks	+14 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/hosted.dart	View	1	2 chunks	+41 lines, -38 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/validator/dependency.dart	View	1	1 chunk	+32 lines, -28 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

PubspecCache already does this while solving. Why do it here?

5 years, 7 months ago (2015-05-05 22:14:50 UTC) #2

Bob Nystrom

LGTM, very nice! https://codereview.chromium.org/1113363004/diff/20001/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart File sdk/lib/_internal/pub/lib/src/solver/version_solver.dart (right): https://codereview.chromium.org/1113363004/diff/20001/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart#newcode237 sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:237: _pubspecs[id] = pubspec; Add a little ...

5 years, 7 months ago (2015-05-06 17:35:09 UTC) #3

nweiz

Committed patchset #3 (id:40001) manually as 45571 (presubmit successful).

5 years, 7 months ago (2015-05-06 18:25:46 UTC) #5

nweiz

5 years, 7 months ago (2015-05-06 18:29:41 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1113363004/diff/20001/sdk/lib/_internal/pub/l...
File sdk/lib/_internal/pub/lib/src/solver/version_solver.dart (right):

https://codereview.chromium.org/1113363004/diff/20001/sdk/lib/_internal/pub/l...
sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:237: _pubspecs[id] =
pubspec;
On 2015/05/06 17:35:09, Bob Nystrom wrote:
> Add a little comment above this like "eagerly cache the pubspec now since we
> have it".

Done.

Expand Messages | Collapse Messages