Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1112793003: Refactor SimpleTypeInferrer.visitGetterSend and visitStaticSend. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor SimpleTypeInferrer.visitGetterSend and visitStaticSend. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -51 lines) Patch
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 chunk +1 line, -12 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 5 chunks +240 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-04-29 10:35:56 UTC) #2
karlklose
LGTM.
5 years, 7 months ago (2015-04-29 10:57:53 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-04-29 11:59:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698