Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1112743002: Add a mapUrl parameter to parse() and parseJson(). (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_maps.git@master
Visibility:
Public.

Description

Add a mapUrl parameter to parse() and parseJson(). Closes #2 R=sigmund@google.com Committed: https://github.com/dart-lang/source_maps/commit/ea266bf177f14e4a6332e744a0a1299631603d37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/parser.dart View 7 chunks +30 lines, -13 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/parser_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
5 years, 7 months ago (2015-04-29 00:02:41 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 7 months ago (2015-04-29 04:48:00 UTC) #3
nweiz
5 years, 7 months ago (2015-04-29 18:24:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea266bf177f14e4a6332e744a0a1299631603d37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698