Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1112473002: Refactor SimpleTypeInferrer.visitSuperSend and deprecate ResolvedVisitor.visitSuperSend. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor SimpleTypeInferrer.visitSuperSend and deprecate ResolvedVisitor.visitSuperSend. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45440

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Update cf. comment + fix bad merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -32 lines) Patch
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 2 2 chunks +212 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-28 08:45:49 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1112473002/diff/1/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right): https://codereview.chromium.org/1112473002/diff/1/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart#newcode994 pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:994: // TODO(ngeoffray): We could do better here if ...
5 years, 8 months ago (2015-04-28 08:59:35 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 45440 (presubmit successful).
5 years, 8 months ago (2015-04-28 09:20:02 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-28 09:25:22 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1112473002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1112473002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:994: //
TODO(ngeoffray): We could do better here if we knew what we
On 2015/04/28 08:59:35, karlklose wrote:
> Maybe we should change the assignee of the TODOs in the type inferrer.

Done. herhut for now.

Powered by Google App Engine
This is Rietveld 408576698