Issue 11118025: Extract common logic from Backend.BaseClassName().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11118025: Extract common logic from Backend.BaseClassName(). (Closed)

Created:
8 years, 2 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -37 lines)			Patch
	M	lib/html/scripts/systemhtml.py	View		2 chunks	+13 lines, -16 lines	0 comments	Download
	M	lib/html/scripts/systemnative.py	View		2 chunks	+3 lines, -21 lines	0 comments	Download

Total messages: 2 (0 generated)

Anton Muhin

8 years, 2 months ago (2012-10-12 17:43:33 UTC) #2

lgtm, but the whole logic might be worth a separate method