Issue 11118020: dart2js_mirrors_test added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11118020: dart2js_mirrors_test added (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2js_mirrors_test added Committed: https://code.google.com/p/dart/source/detail?r=13652

Patch Set 2 : Library comment updated #

Total comments: 2

Patch Set 3 : TODO added #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
M	lib/compiler/implementation/lib/mirrors.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/mirrors/mirrors.dart	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+4 lines, -1 line	0 comments	Download
A	tests/lib/mirrors/dart2js_mirrors_test.dart	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11118020/diff/2001/lib/compiler/implementation/lib/mirrors.dart File lib/compiler/implementation/lib/mirrors.dart (right): https://codereview.chromium.org/11118020/diff/2001/lib/compiler/implementation/lib/mirrors.dart#newcode19 lib/compiler/implementation/lib/mirrors.dart:19: class _Mirrors { So this is some hidden ...

8 years, 2 months ago (2012-10-15 10:35:46 UTC) #2

Johnni Winther

8 years, 2 months ago (2012-10-15 10:50:18 UTC) #3

https://codereview.chromium.org/11118020/diff/2001/lib/compiler/implementatio...
File lib/compiler/implementation/lib/mirrors.dart (right):

https://codereview.chromium.org/11118020/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/lib/mirrors.dart:19: class _Mirrors {
On 2012/10/15 10:35:46, Lasse Reichstein Nielsen wrote:
> So this is some hidden magic class that the mirrors.dart file depends on?
> Shouldn't it just be a non-magical class with external methods?

Yes. Adding a TODO.