Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 11116009: Restore _TimerFactory class. (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years, 2 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, Anton Muhin
Visibility:
Public.

Description

Restore _TimerFactory class. Seems like Dartium is directly storing the closure and not calling _setTimeFactoryClosure. Committed: https://code.google.com/p/dart/source/detail?r=13595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M dart/lib/isolate/timer.dart View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
TBR to make the build green.
8 years, 2 months ago (2012-10-12 06:41:18 UTC) #1
Mads Ager (google)
8 years, 2 months ago (2012-10-12 07:03:24 UTC) #2
LGTM, that didn't use to be the case. Anton can probably provide more
background.

Powered by Google App Engine
This is Rietveld 408576698