Issue 11112014: Change test so that it does not use the built-in 'library'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11112014: Change test so that it does not use the built-in 'library'. (Closed)

Created:
8 years, 2 months ago by karlklose

Modified:
8 years, 2 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change test so that it does not use the built-in 'library'. According to the spec it is not illegal to use 'library' as a library prefix. However, dart2js does not accept (http://dartbug.com/5825). Since the name of the prefix is not important to this test, I changed the name. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=13609

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	tests/language/call_constructor_on_unresolvable_class_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://codereview.chromium.org/11112014/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (left): https://codereview.chromium.org/11112014/diff/1/tests/language/language_dart2js.status#oldcode61 tests/language/language_dart2js.status:61: call_constructor_on_unresolvable_class_test/03: Fail # http://dartbug.com/5825 Do you need to fix ...

8 years, 2 months ago (2012-10-12 10:52:29 UTC) #3

karlklose

8 years, 2 months ago (2012-10-12 11:01:29 UTC) #4

https://codereview.chromium.org/11112014/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (left):

https://codereview.chromium.org/11112014/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:61:
call_constructor_on_unresolvable_class_test/03: Fail # http://dartbug.com/5825
No, it is still failing on the dart2dart buildbot.

Expand Messages | Collapse Messages