Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 11111017: Re-land r13557 on behalf of Alexander. (Closed)

Created:
8 years, 2 months ago by kasperl
Modified:
8 years, 2 months ago
Reviewers:
ahe, aam-me
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-land r13557 on behalf of Alexander. This reverts commit r13585 but includes a small fix to the resolver tests. R=ahe@google.com,aprelev@gmail.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -101 lines) Patch
M lib/compiler/implementation/compile_time_constants.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 chunk +29 lines, -11 lines 0 comments Download
M lib/compiler/implementation/resolver.dart View 8 chunks +163 lines, -77 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/types/concrete_types_inferrer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/compiler/implementation/types/types.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/compiler/implementation/universe/universe.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 4 chunks +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 2 months ago (2012-10-12 11:25:04 UTC) #1
kasperl
TBR'ed. Will watch the build bots closely (fingers crossed).
8 years, 2 months ago (2012-10-12 11:28:28 UTC) #2
aam-me
8 years, 2 months ago (2012-10-12 11:39:22 UTC) #3
LGTM! Thanks!

Powered by Google App Engine
This is Rietveld 408576698