Make the solver deterministic (again).

Make the solver deterministic (again).

This also caps the log transcript size.

BUG=https://code.google.com/p/dart/issues/detail?id=15547
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31072

[Bob Nystrom, 2013-12-10 00:59:10]

When I made the solver defer network requests, I accidentally introduced a
dependency on the order that dependencies appear in the pubspec. Oops.

This fixes that. It also eases memory usage in cases where the solver gets
ratholed. I still want to handle those cases better, but with this fix it
usually won't run out of memory.

[nweiz, 2013-12-10 01:18:05]

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/log.dart:127: // Keep a rolling log of the most
recent entries.
I'm not sure it's correct to roll off the first entries. I think it's likely
that the most informative log entries are going to be the earlier ones, so it
may just be better to discard the entries after the 10,000th. They're likely to
just be repeats of the patterns of the first 10,000 anyway.

Another possibility would be to keep the first 5,000 and the last 5,000 and trim
from in the middle. That would be more complicated to implement, but very likely
to keep all of the relevant information.

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/dependency_queue.dart (right):

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/dependency_queue.dart:68: // Sort the
selected/locked packages by name just to ensure it's
"it" -> "the solver"

[Bob Nystrom, 2013-12-11 00:45:13]

Thanks!

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/log.dart:127: // Keep a rolling log of the most
recent entries.
On 2013/12/10 01:18:05, nweiz wrote:
> I'm not sure it's correct to roll off the first entries. I think it's likely
> that the most informative log entries are going to be the earlier ones, so it
> may just be better to discard the entries after the 10,000th. They're likely
to
> just be repeats of the patterns of the first 10,000 anyway.
> 
> Another possibility would be to keep the first 5,000 and the last 5,000 and
trim
> from in the middle. That would be more complicated to implement, but very
likely
> to keep all of the relevant information.

Done.

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/dependency_queue.dart (right):

https://codereview.chromium.org/111103002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/dependency_queue.dart:68: // Sort the
selected/locked packages by name just to ensure it's
On 2013/12/10 01:18:05, nweiz wrote:
> "it" -> "the solver"

Done.

[nweiz, 2013-12-11 06:53:02]

lgtm

https://codereview.chromium.org/111103002/diff/20001/sdk/lib/_internal/pub/te...
File sdk/lib/_internal/pub/test/transcript_test.dart (right):

https://codereview.chromium.org/111103002/diff/20001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/transcript_test.dart:36: }
Add a test where it doesn't discard entries as well.

[Bob Nystrom, 2013-12-11 17:39:35]

Committed patchset #2 manually as r31072 (presubmit successful).

[Bob Nystrom, 2013-12-11 17:40:01]

https://codereview.chromium.org/111103002/diff/20001/sdk/lib/_internal/pub/te...
File sdk/lib/_internal/pub/test/transcript_test.dart (right):

https://codereview.chromium.org/111103002/diff/20001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/transcript_test.dart:36: }
On 2013/12/11 06:53:03, nweiz wrote:
> Add a test where it doesn't discard entries as well.

Done.