Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 11109012: Land Alexander's change that throw on abstract class instantiations. (Closed)

Created:
8 years, 2 months ago by kasperl
Modified:
8 years, 2 months ago
Reviewers:
ahe, aam-me
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Land Alexander's change that throw on abstract class instantiations. This has already been reviewed here: https://chromiumcodereview.appspot.com/11013010/ TBR'ed. R=ahe@google.com,aprelev@gmail.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13610

Patch Set 1 #

Patch Set 2 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M lib/compiler/implementation/lib/js_helper.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 3 chunks +21 lines, -2 lines 0 comments Download
M lib/core/errors.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
8 years, 2 months ago (2012-10-12 11:00:48 UTC) #1
aam-me
8 years, 2 months ago (2012-10-12 12:30:12 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698