Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 11108017: Rename Dartium dart:html implementation classes. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename Dartium dart:html implementation classes. Currently, Dartium implementation classes are named as "_<IDL_Name>Impl" while dart2js implementation classes are named as "_<Dart_Name>Impl". The goal of this patch is to unify the naming across the backends. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13740

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -177 lines) Patch
M lib/html/dartium/html_dartium.dart View 90 chunks +146 lines, -146 lines 0 comments Download
M lib/html/scripts/generator.py View 1 1 chunk +6 lines, -2 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 1 6 chunks +21 lines, -21 lines 0 comments Download
M lib/html/scripts/systemnative.py View 4 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 2 months ago (2012-10-12 15:33:37 UTC) #1
Anton Muhin
https://codereview.chromium.org/11108017/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11108017/diff/1/lib/html/scripts/generator.py#newcode740 lib/html/scripts/generator.py:740: return ImplementationClassNameForInterfaceName(self.interface_name()) why this has changed? https://codereview.chromium.org/11108017/diff/1/lib/html/scripts/systemhtml.py File lib/html/scripts/systemhtml.py ...
8 years, 2 months ago (2012-10-12 17:50:42 UTC) #2
podivilov
https://codereview.chromium.org/11108017/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11108017/diff/1/lib/html/scripts/generator.py#newcode740 lib/html/scripts/generator.py:740: return ImplementationClassNameForInterfaceName(self.interface_name()) On 2012/10/12 17:50:42, Anton Muhin wrote: > ...
8 years, 2 months ago (2012-10-17 12:57:45 UTC) #3
Anton Muhin
8 years, 2 months ago (2012-10-17 14:01:54 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698