Issue 11103029: - Windows' not Unix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11103029: - Windows' not Unix. (Closed)

Created:
8 years, 2 months ago by Ivan Posva

Modified:
8 years, 2 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Windows' not Unix. Committed: https://code.google.com/p/dart/source/detail?r=13516

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/tools/make_version.py	View		2 chunks	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ricow1

8 years, 2 months ago (2012-10-11 08:45:30 UTC) #2

https://codereview.chromium.org/11103029/diff/1/runtime/tools/make_version.py
File runtime/tools/make_version.py (right):

https://codereview.chromium.org/11103029/diff/1/runtime/tools/make_version.py...
runtime/tools/make_version.py:8: import pwd
You are still importing it

https://codereview.chromium.org/11103029/diff/1/runtime/tools/make_version.py...
runtime/tools/make_version.py:18: '$1 == "%s" {print $2}' % (part),
I don't think this will work either

Expand Messages | Collapse Messages