Issue 11099033: Rename WebKit's WheelEvent.wheelDelta{X,Y} to W3C WheelEvent.delta{X,Y}.

Issue 11099033: Rename WebKit's WheelEvent.wheelDelta{X,Y} to W3C WheelEvent.delta{X,Y}. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
podivilov, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename WebKit's WheelEvent.wheelDelta{X,Y} to W3C WheelEvent.delta{X,Y}. Also remove WheelEvent.wheelDelta. We originally have done that for dart2js, but that broke Dartium support. Instead of removal, just rename to generate binding code still. R=blois@google.com,podivilov@chromium.org BUG=5756 Committed: https://code.google.com/p/dart/source/detail?r=13476

Patch Set 1 #

Total comments: 3

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -26 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	2 chunks	+10 lines, -8 lines	0 comments	Download
M	lib/html/idl/dart/dart.idl	View	1 chunk	+10 lines, -1 line	3 comments	Download
M	lib/html/scripts/htmlrenamer.py	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_WheelEvent.darttemplate	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	lib/html/templates/html/interface/interface_WheelEvent.darttemplate	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://codereview.chromium.org/11099033/diff/1/lib/html/idl/dart/dart.idl File lib/html/idl/dart/dart.idl (right): https://codereview.chromium.org/11099033/diff/1/lib/html/idl/dart/dart.idl#newcode399 lib/html/idl/dart/dart.idl:399: [DartName=deltaX] readonly attribute long wheelDeltaX; Could you please add ...

8 years, 2 months ago (2012-10-10 12:34:24 UTC) #2

Anton Muhin

8 years, 2 months ago (2012-10-10 12:37:00 UTC) #3

blois

8 years, 2 months ago (2012-10-10 16:02:03 UTC) #5

https://codereview.chromium.org/11099033/diff/1/lib/html/idl/dart/dart.idl
File lib/html/idl/dart/dart.idl (right):

https://codereview.chromium.org/11099033/diff/1/lib/html/idl/dart/dart.idl#ne...
lib/html/idl/dart/dart.idl:399: [DartName=deltaX] readonly attribute long
wheelDeltaX;
These are longs here, but the intention of changing them to deltaX/deltaY is to
emulate the W3C WheelEvent proposal, which has them as floats-
http://html5labs.interoperabilitybridges.com/dom4events/#constructors-wheelevent

I believe that exposing them as nums would be safest, given the differences
between browsers and touch devices.

Expand Messages | Collapse Messages