Fix path handling in tools/version.dart so that it does not matter where we call this from.

Fix path handling in tools/version.dart so that it does not matter where we call this from.
Committed: https://code.google.com/p/dart/source/detail?r=13525

[Søren Gjesse, 2012-10-11 09:07:31]

lgtm

[Mads Ager (google), 2012-10-11 09:14:11]

https://codereview.chromium.org/11098066/diff/1/tools/version.dart
File tools/version.dart (right):

https://codereview.chromium.org/11098066/diff/1/tools/version.dart#newcode8
tools/version.dart:8: Version version = new Version("tools/VERSION");
Wait a tick! directoryPath is a path, right?

Maybe the version constructor should accept a Path and use toNativePath on it to
get the platform string?

https://codereview.chromium.org/11098066/diff/1/tools/version.dart#newcode9
tools/version.dart:9: Future f = version.getVersion();
scriptPath.append('VERSION') will give you a new extended path. You can do
toNativePath on that.

[ricow1, 2012-10-11 09:25:33]

PTAL

https://codereview.chromium.org/11098066/diff/1/tools/version.dart
File tools/version.dart (right):

https://codereview.chromium.org/11098066/diff/1/tools/version.dart#newcode8
tools/version.dart:8: Version version = new Version("tools/VERSION");
On 2012/10/11 09:14:11, Mads Ager wrote:
> Wait a tick! directoryPath is a path, right?
> 
> Maybe the version constructor should accept a Path and use toNativePath on it
to
> get the platform string?
> 

Done.

https://codereview.chromium.org/11098066/diff/1/tools/version.dart#newcode9
tools/version.dart:9: Future f = version.getVersion();
On 2012/10/11 09:14:11, Mads Ager wrote:
> scriptPath.append('VERSION') will give you a new extended path. You can do
> toNativePath on that.

Done.

[Mads Ager (google), 2012-10-11 09:28:01]

LGTM