Make WheelEvent.delta{X,Y} return num, not int.

Make WheelEvent.delta{X,Y} return num, not int.

That requires hiding native implementation with private prefix.

R=blois@google.com,podivilov@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=13608

[blois, 2012-10-10 18:46:02]

Looks good to me, one inline question.

https://codereview.chromium.org/11098052/diff/1/lib/html/idl/dart/dart.idl
File lib/html/idl/dart/dart.idl (right):

https://codereview.chromium.org/11098052/diff/1/lib/html/idl/dart/dart.idl#ne...
lib/html/idl/dart/dart.idl:400: [DartName=_wheelDeltaY] readonly attribute long
wheelDeltaY;
Can we not use htmlrenamer.py to make _wheelDeltaX/Y private members?

[Anton Muhin, 2012-10-11 13:04:06]

https://codereview.chromium.org/11098052/diff/1/lib/html/idl/dart/dart.idl
File lib/html/idl/dart/dart.idl (right):

https://codereview.chromium.org/11098052/diff/1/lib/html/idl/dart/dart.idl#ne...
lib/html/idl/dart/dart.idl:400: [DartName=_wheelDeltaY] readonly attribute long
wheelDeltaY;
Sorry, Pete, do you suggest to move the logic in to htmlrenamer or out of it?

On 2012/10/10 18:46:02, blois wrote:
> Can we not use htmlrenamer.py to make _wheelDeltaX/Y private members?

[Anton Muhin, 2012-10-11 18:37:25]

Thanks a lot for suggestion, Pete: that is slightly different (add $dom_
prefix), but I agree it looks cleaner than dedicated private support.

PTAL

https://codereview.chromium.org/11098052/diff/6001/lib/html/scripts/htmlrenam...
File lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11098052/diff/6001/lib/html/scripts/htmlrenam...
lib/html/scripts/htmlrenamer.py:39: 'DocumentFragment.querySelector',
just sorting

https://codereview.chromium.org/11098052/diff/6001/lib/html/scripts/htmlrenam...
lib/html/scripts/htmlrenamer.py:83: 'WheelEvent.wheelDeltaX',
these are added

https://codereview.chromium.org/11098052/diff/6001/lib/html/scripts/htmlrenam...
lib/html/scripts/htmlrenamer.py:273: "WheelEvent.wheelDelta",
for consistency

[blois, 2012-10-11 19:34:59]

lgtm