Issue 11098028: Revert r13442. The extension fails to install under Windows, and the sentinel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11098028: Revert r13442. The extension fails to install under Windows, and the sentinel (Closed)

Created:
8 years, 2 months ago by gram

Modified:
8 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r13442. The extension fails to install under Windows, and the sentinel message approach does not work on Mac; Mac seems to need the old timeout approach. So only Linux works at this point. Committed: https://code.google.com/p/dart/source/detail?r=13450

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -42 lines)			Patch
	M	pkg/unittest/test_controller.js	View		1 chunk	+1 line, -23 lines	0 comments	Download
	M	tools/testing/run_selenium.py	View		3 chunks	+6 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

8 years, 2 months ago (2012-10-09 22:46:10 UTC) #2

lgtm -- and the only reason it works on linux is because the linux bot is
running drt, which doesn't use run_selenium at all

Expand Messages | Collapse Messages